[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address compari
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison |
Date: |
Mon, 07 May 2012 18:45:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 |
On 05/07/2012 06:43 PM, Alexander Graf wrote:
>
> On 07.05.2012, at 18:41, Fabien Chouteau wrote:
>
>> Use size mask in both operands of effective address comparison.
>> This is the expected as the size of EPN field in MAS2 depends on page
>> size.
>>
>> Definition of EPN field from e500v2 RM:
>> EPN Effective page number: Depending on page size, only the bits
>> associated with a page boundary are valid. Bits that represent offsets
>> within a page are ignored and should be cleared.
>>
>> There is a similar (but more complicated) definition in PowerISA V2.06.
>
> Would it make sense to do this at tlbwe time? That path is a bit less hot
> that the tlb check :).
Why not, I'll check that tomorrow.
Thanks,
--
Fabien Chouteau