[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED
Date: Wed, 09 May 2012 14:15:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

Am 08.05.2012 16:51, schrieb Paolo Bonzini:
> QED's opaque data includes a pointer back to the BlockDriverState.
> This breaks when bdrv_append shuffles data between bs_new and bs_top.
> To avoid this, add a "rebind" function that tells the driver about
> the new relationship between the BlockDriverState and its opaque.
> The patch also adds rebind to VVFAT for completeness, even though
> it is not used with live snapshots.
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

I still don't like this patch. We'll not get the proper solution in time
for 1.1, but I hope that we can get rid of bdrv_rebind() again when
BlockDriverState and the block device backend are split and devices no
longer have direct pointers to BlockDriverStates.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]