[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1 04/22] block: fully delete bs->file when clo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1.1 04/22] block: fully delete bs->file when closing |
Date: |
Wed, 09 May 2012 14:59:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0 |
Il 09/05/2012 14:22, Kevin Wolf ha scritto:
> Am 08.05.2012 16:51, schrieb Paolo Bonzini:
>> We are reusing bs->file across close/open, which may not cause any
>> known bugs but is a recipe for trouble. Prefer bdrv_delete, and
>> enjoy the new invariant in the implementation of bdrv_delete.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> I think bs->file is changed during bdrv_open() for all block drivers
> that make use of it. We do however leak the old bs->file then.
Right, bdrv_open_common has bs->file = NULL. See also patch 9 in the
series...
Paolo
- [Qemu-devel] [PATCH 1.1 00/22] Rebased queue of block patches., Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 02/22] block: another bdrv_append fix, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 03/22] block: do not reuse the backing file across bdrv_close/bdrv_open, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 05/22] block: add block_job_sleep_ns, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 04/22] block: fully delete bs->file when closing, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 06/22] block: wait for job callback in block_job_cancel_sync, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 07/22] block: simplify path_is_absolute, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 09/22] block: move field reset from bdrv_open_common to bdrv_close, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 08/22] block: protect path_has_protocol from filenames with colons, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 10/22] qemu-img: make "info" backing file output correct and easier to use, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 13/22] stream: fix sectors not allocated test, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 16/22] stream: fix HMP block_job_set_speed, Paolo Bonzini, 2012/05/08
- [Qemu-devel] [PATCH 1.1 14/22] stream: add testcase for partial streaming, Paolo Bonzini, 2012/05/08