[Qemu-devel] [PATCH 05/22] lm32: avoid buffer overrun

[Jim Meyering]

From: Jim Meyering <address@hidden>

Actually do what the comment says, using pstrcpy to NUL-terminate:
strncpy does not always do that.

Signed-off-by: Jim Meyering <address@hidden>
---
 hw/lm32_hwsetup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/lm32_hwsetup.h b/hw/lm32_hwsetup.h
index 8fc285e..70dc61f 100644
--- a/hw/lm32_hwsetup.h
+++ b/hw/lm32_hwsetup.h
@@ -96,7 +96,7 @@ static inline void hwsetup_add_tag(HWSetup *hw, enum 
hwsetup_tag t)

 static inline void hwsetup_add_str(HWSetup *hw, const char *str)
 {
-    strncpy(hw->ptr, str, 31); /* make sure last byte is zero */
+    pstrcpy(hw->ptr, 32, str);
     hw->ptr += 32;
 }

-- 
1.7.10.1.487.ga3935e6