[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info q
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree |
|
Date: |
Fri, 11 May 2012 16:45:37 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 11/05/2012 16:20, Andreas Färber ha scritto:
> char *string = NULL;
>
>> >
>> > mo = string_output_visitor_new();
>> > - object_property_get(obj, string_output_get_visitor(mo), name, NULL);
>> > + object_property_get(obj, string_output_get_visitor(mo), name, errp);
> If we do error checking we should be consequent and do:
>
> if (!error_is_set(errp)) {
>
>> > string = string_output_get_string(mo);
> }
>
>> > string_output_visitor_cleanup(mo);
Or just say that it is part of the string_output_visitor interface that
in case of an error the returned string is NULL.
Paolo
- Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object, (continued)
[Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 07/21] qdev: fix -device foo,?, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 09/21] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 13/21] qdev: clean up global properties, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 15/21] qdev: fix adding of ptr properties, Paolo Bonzini, 2012/05/02