[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and st

From: andrzej zaborowski
Subject: Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and store ARMCPU
Date: Fri, 11 May 2012 22:37:08 +0200

On 11 May 2012 13:16, Peter Maydell <address@hidden> wrote:
> On 10 May 2012 01:14, Andreas Färber <address@hidden> wrote:
>> Also use cpu_reset() in place of cpu_state_reset().
>> Signed-off-by: Andreas Färber <address@hidden>
> The pxa2xx stuff is probably going to clash with the cp15
> rework, but I guess we'll sort that out when one or the
> other of these series hits master.
> Acked-by: Peter Maydell <address@hidden>

Also looks good to me.

> (The stuff pxa2xx.c is doing to CPUARMState is a really
> gross layering violation, incidentally.)

The code reflects what the hardware is doing though.  One could argue
that if a hardware emulator divides things into layers where the real
hardware violates those layers then the division is not fully correct.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]