[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s |
Date: |
Sun, 13 May 2012 22:30:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 11.05.2012 14:52, schrieb Andreas Färber:
> Am 10.05.2012 23:38, schrieb Peter Maydell:
>> On 10 May 2012 01:14, Andreas Färber <address@hidden> wrote:
>>> Fix tab indentations of comments, add braces, use cpu_reset().
>>>
>>> Signed-off-by: Andreas Färber <address@hidden>
>>> ---
>>> hw/nseries.c | 6 +++---
>>> hw/omap.h | 2 +-
>>> hw/omap1.c | 20 +++++++++++---------
>>> hw/omap2.c | 8 ++++----
>>> hw/omap_sx1.c | 2 +-
>>> hw/palm.c | 2 +-
>>> 6 files changed, 21 insertions(+), 19 deletions(-)
>>
>> There are some structs here which use the name 'cpu' for
>> a 'struct omap_mpu_state_s *', which leads to ugliness
>> like s->cpu->cpu->env. (We shouldn't be trying to fix that
>> here, just a passing comment.)
>
> Now that we have qom-next, we are no longer limited to the concept of
> self-contained series so I can try to turn that into s->mpu->cpu->env
> the weekend. Not perfect either, but better distinguishable.
Patch sent, please review.
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH next v2 35/74] armv7m: Use cpu_arm_init() to obtain ARMCPU, (continued)
- [Qemu-devel] [PATCH next v2 43/74] lm32_boards: Store LM32CPU in ResetInfo, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 42/74] lm32_boards: Use cpu_lm32_init() to obtain LM32CPU, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 38/74] target-sh4: Let cpu_sh4_init() return SuperHCPU, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 44/74] milkymist: Use cpu_lm32_init() to obtain LM32CPU, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 46/74] target-xtensa: Let cpu_xtensa_init() return XtensaCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 39/74] r2d: Use cpu_sh4_init() to obtain SuperHCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 47/74] xtensa_sim: Use cpu_xtensa_init() to obtain XtensaCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 51/74] target-cris: Reindent cpu_cris_init(), Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 49/74] xtensa_lx60: Use cpu_xtensa_init() to obtain XtensaCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 52/74] target-cris: Let cpu_cris_init() return CRISCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 53/74] axis_dev88: Use cpu_cris_init() to obtain CRISCPU, Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 50/74] xtensa_lx60: Pass XtensaCPU to lx60_reset(), Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 48/74] xtensa_sim: Pass XtensaCPU to sim_reset(), Andreas Färber, 2012/05/09
[Qemu-devel] [PATCH next v2 58/74] petalogix_s3adsp1800_mmu: Use cpu_mb_init() to obtain MicroBlazeCPU, Andreas Färber, 2012/05/09