Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

[Blue Swirl]

On Mon, May 14, 2012 at 4:15 PM, Andreas Färber <address@hidden> wrote:
> Am 10.05.2012 02:13, schrieb Andreas Färber:
>> Andreas Färber (74):
> [...]
>>   target-sparc: Let cpu_sparc_init() return SPARCCPU
>>   sun4m: Use cpu_sparc_init() to obtain SPARCCPU
>>   sun4m: Pass SPARCCPU to {main,secondary}_cpu_reset()
>>   sun4u: Use cpu_sparc_init() to obtain SPARCCPU
>>   sun4u: Let cpu_devinit() return SPARCCPU
>>   sun4u: Store SPARCCPU in ResetData
>>   leon3: Use cpu_sparc_init() to obtain SPARCCPU
>>   leon3: Store SPARCCPU in ResetData
> [...]
>>   Kill off cpu_state_reset()
>
> Ping! Blue, can you ack please?

What was again the purpose of all these changes, 00/74 only mentions
killing cpu_state_reset()? For example two CPU types (SPARCCPU vs.
CPUSPARCState) doesn't look very useful, is that needed?

Otherwise the patches look pretty safe ("if it compiles, it works").

>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg