[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by

From: Bjorn Helgaas
Subject: Re: [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by other drivers
Date: Mon, 14 May 2012 15:20:40 -0600

> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index dc25da3..b437225 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -770,6 +770,14 @@ static inline int pci_write_config_dword(const struct 
> pci_dev *dev, int where,
>        return pci_bus_write_config_dword(dev->bus, dev->devfn, where, val);
>  }
> +/* user-space driven config access */
> +extern int pci_user_read_config_byte(struct pci_dev *dev, int where, u8 
> *val);
> +extern int pci_user_read_config_word(struct pci_dev *dev, int where, u16 
> *val);
> +extern int pci_user_read_config_dword(struct pci_dev *dev, int where, u32 
> *val);
> +extern int pci_user_write_config_byte(struct pci_dev *dev, int where, u8 
> val);
> +extern int pci_user_write_config_word(struct pci_dev *dev, int where, u16 
> val);
> +extern int pci_user_write_config_dword(struct pci_dev *dev, int where, u32 
> val);

If you repost this, can you remove the externs when you move these
declarations?  I know the file's currently a random mix, but we might
as well make a tiny improvement.

Looks fine to me otherwise, and if you don't have any other reason to
update this series, don't worry about it.

Acked-by: Bjorn Helgaas <address@hidden>

>  int __must_check pci_enable_device(struct pci_dev *dev);
>  int __must_check pci_enable_device_io(struct pci_dev *dev);
>  int __must_check pci_enable_device_mem(struct pci_dev *dev);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]