[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject. |
Date: |
Tue, 15 May 2012 23:52:22 +0300 |
On Tue, May 15, 2012 at 04:26:36PM +0100, Anthony PERARD wrote:
> This hotplug state will be used to remove a device without the guest
> cooperation.
>
> Signed-off-by: Anthony PERARD <address@hidden>
This can crash guest, can't it? If you are fine with crashing guest,
we already let you do this:
- delete device
- reset guest
no need for new flags.
> ---
> hw/acpi_piix4.c | 5 +++++
> hw/pci.h | 1 +
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index 585da4e..dfd5a9d 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -587,6 +587,11 @@ static int piix4_device_hotplug(DeviceState *qdev,
> PCIDevice *dev,
> return 0;
> }
>
> + if (state == PCI_FORCE_EJECT) {
> + acpi_piix_eject_slot(s, 1 << slot);
> + return 0;
> + }
> +
> if (state == PCI_HOTPLUG_ENABLED) {
> enable_device(s, slot);
> } else {
> diff --git a/hw/pci.h b/hw/pci.h
> index 8d0aa49..3b61e43 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -273,6 +273,7 @@ typedef enum {
> PCI_HOTPLUG_DISABLED,
> PCI_HOTPLUG_ENABLED,
> PCI_COLDPLUG_ENABLED,
> + PCI_FORCE_EJECT,
> } PCIHotplugState;
>
> typedef int (*pci_hotplug_fn)(DeviceState *qdev, PCIDevice *pci_dev,
> --
> Anthony PERARD
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, (continued)
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Stefano Stabellini, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Stefano Stabellini, 2012/05/16
- Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM, Michael S. Tsirkin, 2012/05/16
[Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Stefano Stabellini, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Stefano Stabellini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony Liguori, 2012/05/16
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
[Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback., Anthony PERARD, 2012/05/15