qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset


From: Stefan Weil
Subject: [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset
Date: Wed, 16 May 2012 07:53:13 +0200

Only the first 4 or 8 bytes were set to 0.
This bug was found by cppcheck.

Signed-off-by: Stefan Weil <address@hidden>
---
 hw/kvm/apic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
index ffe7a52..a0ab503 100644
--- a/hw/kvm/apic.c
+++ b/hw/kvm/apic.c
@@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct 
kvm_lapic_state *kapic)
     APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
     int i;
 
-    memset(kapic, 0, sizeof(kapic));
+    memset(kapic, 0, sizeof(*kapic));
     kvm_apic_set_reg(kapic, 0x2, s->id << 24);
     kvm_apic_set_reg(kapic, 0x8, s->tpr);
     kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24);
-- 
1.7.10




reply via email to

[Prev in Thread] Current Thread [Next in Thread]