[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to acc

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX
Date: Thu, 17 May 2012 19:26:17 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/17/2012 07:18 PM, Alexander Graf wrote:

On 16.05.2012, at 12:29, Christian Borntraeger wrote:

On 03/05/12 16:33, Peter Maydell wrote:
On 3 May 2012 15:27, Christian Borntraeger<address@hidden>  wrote:
commit 17df768c1e4580f03301d18ea938d3557d441911
  load_image_targphys() should enforce the max size

caused some problems with external kernel and specific ram sizes on s390:

We load the external kernel with

          kernel_size = load_image_targphys(kernel_filename, 0, ram_size);

Since load_image_targphys is declared as taking an int for max_sz, this will
fail for ram sizes>  INT_MAX.
Lets change the max_sz parameter to a uint64_t.

Signed-off-by: Christian Borntraeger<address@hidden>

A patch equivalent to this has already been submitted:
We should be applying that one, it has already been reviewed.



can you apply the patchwork patch for 1.1?

Ping? Still missing in rc2.



Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]