qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom-next 00/22] ARM: QOM cpu_reset() followups


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH qom-next 00/22] ARM: QOM cpu_reset() followups
Date: Fri, 18 May 2012 14:13:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Am 15.05.2012 13:14, schrieb Peter Maydell:
> On 14 May 2012 18:31, Andreas Färber <address@hidden> wrote:
>> Following up on your remark about ugly naming as a consequence of my CPU 
>> reset
>> patches and my OMAP field rename, here's a few more patches.
>>
>> Patch 1 is spelling fixes in a comment and could be pulled into 1.1.
>>
>> Patches 2-7 fix some more naming ugliness that I missed when running
>>  because they were just "cpu->cpu". Again, fix by
>> using "mpu" rather than "cpu".
>>
>> Patches 8-19 are what I had in mind with my choice of variable placement in
>> the reset series. They clean up expressions in some targets, at the same time
>> incur changes to other targets which would be needed for wiring up the CPU
>> later anyway.
>>
>> Patches 20-22 are preparations cherry-picked from QOM CPUState part 4, which
>> I'm including here since you indicated there might be a conflict with cp15 or
>> qemu-linaro work.
>>
>> Please ack and indicate which merge order you would prefer.
> 
> Series
> Acked-by: Peter Maydell <address@hidden>
> (although note my remark about the Zynq board change).

Thanks, applied 2-11, 13-14, 16-18 to minimize v2.

Patch 1 is irrelevant to my refactorings so I'd ask you, Peter, to queue
it in case some other ARM patch for 1.1 comes along.

Andreas

> You might want to look at whether the pxa2xx changes conflict with the
> cp15 series I just posted. Other than not wanting to have to respin
> that series, I don't much care about merge order.
> 
> thanks
> -- PMM

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]