Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

[Gerd Hoffmann]

  Hi,

> +    if (info->qxl0_guest_bug != -1 && info->qxl0_mode != -1) {
> +        monitor_printf(mon, " qxl0\n");
> +        monitor_printf(mon, "   guest_bug: %"PRIu64"d\n", 
> info->qxl0_guest_bug);
> +        monitor_printf(mon, "        mode: %s\n",
> +                SpiceQueryQXLMode_lookup[info->qxl0_mode]);
> +    }

Anything else we might want export while being at it?  For example
whenever guest drivers use sync or async io commands?

What about secondary displays?

> +/* helpers for spice_info. only show first device */
> +int qxl0_guest_bug(void)
> +{
> +    if (!qxl0) {
> +        return -1;
> +    }
> +    return qxl0->guest_bug;
> +}
> +
> +int qxl0_mode(void)
> +{
> +    if (!qxl0) {
> +        return -1;
> +    }
> +    return qxl0->mode;
> +}

Hmm, that is a bit hackish.  qxl0 exists only for the reason that
displaychangelisteners don't support passing through a opaque pointer
(or other way to get the state).  I'd prefer to get rid of it, not add
more uses, although I can see that it is convenient ...


cheers,
  Gerd