[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected q
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header |
Date: |
Mon, 21 May 2012 13:24:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 21.05.2012 13:06, schrieb Jim Meyering:
>
> Signed-off-by: Jim Meyering <address@hidden>
> ---
> Thanks to Kevin Wolf for the improvement.
>
> block/qcow2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 655799c..c2e49cd 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -919,7 +919,8 @@ int qcow2_update_header(BlockDriverState *bs)
> ret = sizeof(*header);
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + goto fail;
> }
>
> buf += ret;
> --
> 1.7.10.2.552.gaa3bb87
Acked-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH 0/6] plug memory and file-descriptor leaks, Jim Meyering, 2012/05/16
- [Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure, Jim Meyering, 2012/05/16
- [Qemu-devel] [PATCH 5/6] arm-semi: don't leak 1kb user string lock buffer upon TARGET_SYS_OPEN, Jim Meyering, 2012/05/16
- [Qemu-devel] [PATCH 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure, Jim Meyering, 2012/05/16
- [Qemu-devel] [PATCH 6/6] softmmu-semi: fix lock_user* functions not to deref NULL upon OOM, Jim Meyering, 2012/05/16