[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice

From: Anthony PERARD
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice to access a pci device on the host.
Date: Tue, 22 May 2012 13:52:09 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120428 Thunderbird/12.0.1

On 16/05/12 12:24, Konrad Rzeszutek Wilk wrote:
On Tue, Apr 03, 2012 at 04:32:38PM +0100, Anthony PERARD wrote:
Signed-off-by: Anthony PERARD<address@hidden>

Looks good, thought I've just couple of tiny comments:


You might want a comment explaining why 512, and not
a more precise number like 741.

Actually, I only need the first 7 line of the resources file. So this is 399 bytes. I just add a little bit more.

.. snip..
+    do {
+        rc = read(fd,&buf, sizeof (buf) - 1);
+        if (rc<  0&&  errno != EINTR) {
+            rc = -errno;
+            goto out;
+        }
+    } while (rc<  0);

Ok, you read it in. Maybe my 'wc' magic is gone, but this
is what I get:
address@hidden 0000:00:02.0]# cat resource | wc -c
.. snip..

The answer to the life? Can you provide a comment explaining
the reason why it is 42, please?

I just define more than needed, and 42 is a good number :-).
But the maximum I need is probably 7 (for example '0x8086\n', for a vendor id). Or 20, number of digit in LONG_MAX, base 10.

+static int xen_host_pci_get_value(XenHostPCIDevice *d, const char *name,
+                                  unsigned int *pvalue, int base)

Anthony PERARD

reply via email to

[Prev in Thread] Current Thread [Next in Thread]