[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/a9mpcore: Fix compilation failure if physadd
Re: [Qemu-devel] [PATCH] hw/a9mpcore: Fix compilation failure if physaddrs are 64 bit
Tue, 22 May 2012 18:15:45 +0100
On 22 May 2012 18:09, Eric Blake <address@hidden> wrote:
> On 05/22/2012 11:04 AM, Peter Maydell wrote:
>> @@ -75,7 +75,7 @@ static void a9_scu_write(void *opaque, target_phys_addr_t
>> fprintf(stderr, "Invalid size %u in write to a9 scu register %x\n",
>> - size, offset);
>> + size, (uint32_t)offset);
> NACK. %x and (uint32_t) are not necessarily compatible types (some
> platforms implement uint32_t as long). If you use %x, then cast to
> (unsigned int) instead.
Good point, though I think from the fact we have uses of %x for uint32_t
types already in the codebase that we don't try to compile on any of
Patch v2 on the way.