[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux

From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts
Date: Wed, 23 May 2012 18:03:12 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Am 23.05.2012 17:32, schrieb Kevin Wolf:
Am 23.05.2012 17:29, schrieb Stefan Weil:
Am 23.05.2012 10:09, schrieb Stefan Hajnoczi:
On Tue, May 22, 2012 at 10:23 PM, Stefan Weil<address@hidden>   wrote:
The local variables ret, i are only used if __linux__ is defined.

Signed-off-by: Stefan Weil<address@hidden>
   hw/virtio-blk.c |    4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)
The #ifdef __linux__ further down in the function declares the local
hdr variable.  We could move ret and i down into the #ifdef instead of
adding a new one.
I noticed that, but declaring variables anywhere is C++, not C code.
It's called C99.


Maybe, but I already had patches rejected because of that style.
Did this policy change? I'd appreciate that!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]