[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initializ
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind |
Date: |
Wed, 23 May 2012 20:59:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4 |
On 05/22/12 17:29, Alon Levy wrote:
> We can't initialize QXLDevSurfaceCreate field by field because it has a
> pa hole, and so 4 bytes remain uninitialized when building on x86-64, so
> just memset.
So you get valgrind warnings for the hole? why? nobody should ever
access the hole, so the missing initialization should not hurt in theory ...
> Signed-off-by: Alon Levy <address@hidden>
> ---
> ui/spice-display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ui/spice-display.c b/ui/spice-display.c
> index 5418eb3..3e8f0b3 100644
> --- a/ui/spice-display.c
> +++ b/ui/spice-display.c
> @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay
> *ssd)
> {
> QXLDevSurfaceCreate surface;
>
> + memset(&surface, 0, sizeof(surface));
> +
> dprint(1, "%s: %dx%d\n", __FUNCTION__,
> ds_get_width(ssd->ds), ds_get_height(ssd->ds));
>
- [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/22
- [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/22
- [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/22
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24