[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd |
Date: |
Wed, 23 May 2012 15:08:43 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote:
> Build error found by buildbot:
>
> qga/commands-posix.c: In function 'qmp_guest_shutdown':
> qga/commands-posix.c:65: error: 'environ' undeclared (first use in this
> function)
> qga/commands-posix.c:65: error: (Each undeclared identifier is reported only
> once
> qga/commands-posix.c:65: error: for each function it appears in.)
>
> On F16 environ is declared in <unistd.h>, but that obviously doesn't
> happen on all systems.
>
> Tested on OpenBSD 4.9.
>
> PS: I get zillions of -Wno-redundant-decls errors on OpenBSD 4.8 and still
> get other warnnigs if I drop that flag.
>
> configure | 19 +++++++++++++++++++
> qga/commands-posix.c | 6 +++++-
> 2 files changed, 24 insertions(+), 1 deletion(-)
>
Thanks, applied to qga branch. Will send a 1.1 pull request for these.