[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit
Date: Thu, 24 May 2012 09:10:37 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4

On 05/03/12 21:32, malc wrote:
> On Thu, 3 May 2012, Jan Kiszka wrote:
>> Not only clean up enabled voices but any registered one. Backends like
>> pulsaudio rely on unconditional fini handler invocations.
>> This fixes "Memory pool destroyed but not all memory blocks freed!"
>> warnings on VM shutdowns when pa is used.
> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?
> [..snip..]

Waded through the source.  Have to agree with Jan here: Handling this
via VOICE_{ENABLE,DISABLE} isn't going to fly.  It would mean to move
the complete pulseaudio setup (connect to daemon, create streams, create
worker thread, ...).from init() to VOICE_ENABLE so we can cleanup in
VOICE_DISABLE and don't need fini().  This isn't how it is supposed to
work ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]