[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu |
Date: |
Thu, 24 May 2012 14:49:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 24.05.2012 09:42, schrieb Pavel Dovgaluk:
> Prevent disk data loss when closing qemu console window
> under Windows 7.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> os-win32.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/os-win32.c b/os-win32.c
> index ad76370..66c39b8 100644
> --- a/os-win32.c
> +++ b/os-win32.c
> @@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int
> overwrite)
>
> static BOOL WINAPI qemu_ctrl_handler(DWORD type)
> {
> - exit(STATUS_CONTROL_C_EXIT);
> + qemu_system_shutdown_request();
> + /* Windows 7 kills application when the function returns.
> + Sleep here to give QEMU a try for closing */
> + Sleep(10000);
How do we know that 10000 is enough? Shouldn't we rather block until
receipt of some completion signal?
Andreas
> +
> return TRUE;
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg