[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info |
Date: |
Thu, 24 May 2012 14:58:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4 |
On 05/24/12 11:38, Alon Levy wrote:
> For all devices print id, mode and guest_bug status.
Queued up 1+2+4
For this one I wanna have an additional ack from qmp camp.
Also a nit:
> # @SpiceInfo
> #
> # Information about the SPICE session.
> @@ -683,12 +721,17 @@
> #
> # @channels: a list of @SpiceChannel for each active spice channel
> #
> +# @qxl0_mode: Mode of the primary qxl device.
> +#
> +# @qxl0_guest_bug: Guest bug status of primary qxl device.
> +#
Code changed, but docs didn't ...
Otherwise looks fine to me.
cheers,
Gerd
- [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, (continued)
- [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/22
- [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/22
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/23
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24