[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new
Date: Thu, 24 May 2012 15:01:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Am 24.05.2012 14:58, schrieb Anthony Liguori:
> On 05/24/2012 06:51 AM, Paolo Bonzini wrote:
>> Il 24/05/2012 13:43, Markus Armbruster ha scritto:
>>> Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack
>>> additional magic performed by qdev_try_create(), and almost certainly
>>> won't work.
>> True.  With the patches on the list, all that adev_try_create does is
>> really
>>      dev->parent_bus = bus;
>>      bus_add_child(bus, dev);
>> We should change that to a parent_bus property,
> parent_bus is a property with the QOM bus series (which is part of your
> Push, push, series, no?).

Note it's on qom-next already since last night but I discovered a minor
issue where I am going to move some code between two patches of yours
for consistency. Will send out official notices when I'm done.


> You still can't add a bus as a child.  We need a magic child[*] link
> that acts like a clone file.  Shouldn't be hard to add.
> Regards,
> Anthony Liguori
>  so that device_add is
>> really qom-new + qom-set parent_bus.
>> Paolo

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]