[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu
Date: Thu, 24 May 2012 08:11:50 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/24/2012 05:10 AM, Paolo Bonzini wrote:
Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto:
Prevent disk data loss when closing qemu console window
under Windows 7.

Signed-off-by: Pavel Dovgalyuk<address@hidden>
  os-win32.c |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/os-win32.c b/os-win32.c
index ad76370..66c39b8 100644
--- a/os-win32.c
+++ b/os-win32.c
@@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int 

  static BOOL WINAPI qemu_ctrl_handler(DWORD type)
+    qemu_system_shutdown_request();
+    /* Windows 7 kills application when the function returns.
+       Sleep here to give QEMU a try for closing */
+    Sleep(10000);
      return TRUE;

Reviewed-by: Paolo Bonzini<address@hidden>

Anthony, can you queue it for 1.1?

Is that a 10 second sleep? I really think this needs a much, much better commit message. Random sleeps like this are poison and need to be carefully justified.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]