[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info |
Date: |
Thu, 24 May 2012 19:15:37 +0300 |
User-agent: |
Mutt/1.5.21 (2011-07-01) |
On Thu, May 24, 2012 at 02:58:40PM +0200, Gerd Hoffmann wrote:
> On 05/24/12 11:38, Alon Levy wrote:
> > For all devices print id, mode and guest_bug status.
>
> Queued up 1+2+4
Please unqueue "qxl: stop dirty loging when not in vga mode" and I'll
send it again with the separate patch "hw/qxl: ignore guest from
guestbug until reset" that accidentally got squashed into it.
>
> For this one I wanna have an additional ack from qmp camp.
> Also a nit:
>
> > # @SpiceInfo
> > #
> > # Information about the SPICE session.
> > @@ -683,12 +721,17 @@
> > #
> > # @channels: a list of @SpiceChannel for each active spice channel
> > #
> > +# @qxl0_mode: Mode of the primary qxl device.
> > +#
> > +# @qxl0_guest_bug: Guest bug status of primary qxl device.
> > +#
>
> Code changed, but docs didn't ...
>
> Otherwise looks fine to me.
>
> cheers,
> Gerd
>
- [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info, (continued)
- [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/22
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/23
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info,
Alon Levy <=
- [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24