[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump |
Date: |
Mon, 28 May 2012 11:57:46 +0300 |
User-agent: |
Mutt/1.5.21 (2011-07-01) |
On Fri, May 25, 2012 at 04:41:05PM -0300, Luiz Capitulino wrote:
> Converting the screendump command is simple and shouldn't take more than
> or or two patches, the complicated part is to report all errors correctly.
>
> I hope I didn't go too far there, but at least this series does the right
> thing (or is very near to).
>
Reviewed-by: Alon Levy <address@hidden>
> console.c | 7 ++--
> console.h | 5 +--
> cutils.c | 100
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> hmp-commands.hx | 5 ++-
> hmp.c | 9 +++++
> hmp.h | 1 +
> hw/blizzard.c | 4 +--
> hw/g364fb.c | 51 ++++++++++++++++++++--------
> hw/omap_lcdc.c | 60 +++++++++++++++++++++++----------
> hw/qxl.c | 7 ++--
> hw/tcx.c | 96 ++++++++++++++++++++++++++++++++++++++++------------
> hw/vga.c | 38 +++++++++++++--------
> hw/vga_int.h | 3 +-
> hw/vmware_vga.c | 7 ++--
> monitor.c | 6 ----
> qapi-schema.json | 24 +++++++++++++
> qemu-common.h | 7 ++++
> qerror.c | 28 ++++++++++++++--
> qerror.h | 22 ++++++++++--
> qmp-commands.hx | 5 +--
> 20 files changed, 390 insertions(+), 95 deletions(-)
- [Qemu-devel] [PATCH 06/14] cutils: introduce qemu_fwrite_err(), (continued)
- [Qemu-devel] [PATCH 06/14] cutils: introduce qemu_fwrite_err(), Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 07/14] omap_lcdc: rename ppm_save() to omap_ppm_save(), Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 08/14] console: vga_hw_screen_dump_ptr: take an Error argument, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 09/14] vga: ppm_save(): add error handling, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 12/14] tcx: tcx24_screen_dump(): add error handling, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 13/14] tcx: tcx_screen_dump(): add error handling, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 10/14] omap_lcdc: omap_ppm_save(): add error handling, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 14/14] qapi: convert screendump, Luiz Capitulino, 2012/05/25
- [Qemu-devel] [PATCH 11/14] g364fb: g364fb_screen_dump(): add error handling, Luiz Capitulino, 2012/05/25
- Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump,
Alon Levy <=