Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

[guanxuetao]

> Am 25.05.2012 13:29, schrieb Guan Xuetao:
>> This patch adds configure and makefile support for unicore32-softmmu.
>> All puv3-soc devices are put into hw/pkunity directory, so this dir
>> will be added when unicore32-softmmu is selected.
>>
>> Signed-off-by: Guan Xuetao <address@hidden>
>> ---
>>  Makefile.target                       |    5 +++++
>>  arch_init.c                           |    2 ++
>>  arch_init.h                           |    1 +
>>  configure                             |    4 ++++
>>  default-configs/unicore32-softmmu.mak |    4 ++++
>>  5 files changed, 16 insertions(+), 0 deletions(-)
>>  create mode 100644 default-configs/unicore32-softmmu.mak
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 1582904..2f850d3 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -387,6 +387,11 @@ obj-xtensa-y += core-dc232b.o
>>  obj-xtensa-y += core-dc233c.o
>>  obj-xtensa-y += core-fsf.o
>>
>> +obj-unicore32-y += uc32_softmmu.o
>> +obj-unicore32-y += pkunity/puv3.o
>> +obj-unicore32-y += pkunity/puv3_intc.o pkunity/puv3_ost.o
>> pkunity/puv3_gpio.o
>> +obj-unicore32-y += pkunity/puv3_pm.o pkunity/puv3_dma.o
> [snip]
>
> You need to put the Makefile/configure changes into the patches that
> introduce the files please, otherwise they cannot be checked for
> compiler warnings/errors.
>
> Andreas
I think the patch series is considered as a whole, and only
compiling/building one device sim-code doesn't make sense. In fact, when
unicore32-softmmu not enabled, the device sim-code isn't going to be
compiled at all.

Guan Xuetao