Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

[Paolo Bonzini]

Il 29/05/2012 11:47, Andreas Färber ha scritto:
> Am 29.05.2012 11:43, schrieb Paolo Bonzini:
>> Il 29/05/2012 11:28, Andreas Färber ha scritto:
>>> Am 29.05.2012 09:05, schrieb Gerd Hoffmann:
>>>> -  rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d 
>>>> net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d 
>>>> qga/*.o qga/*.d
>>>> -  rm -f qom/*.o qom/*.d
>>>> +  rm -f slirp/*.o audio/*.o block/*.o net/*.o fsdev/*.o ui/*.o qapi/*.o 
>>>> qga/*.o
>>>> +  rm -f qom/*.o
>>>
>>> I think this is calling for a centrally maintained (or automatically
>>> derived) list of build directories.
>>
>> Quite difficult with the abuse of vpath that we currently have... but we
>> can still proceed incrementally.
> 
> For 1.1 I was thinking of something like
> 
> BUILDSUBDIRS=slirp audio block net fsdev ui qapi qga qom
> 
>       for dir in $(BUILDSUBDIRS); do \
>               rm -rf $dir/*.o $dir/*.d; \
>       done
> 
> which possibly could also be reused for the list of *.d includes with
> some clever macro usage.

I think even this is too much for 1.1.  After all the problems come only
if you modify the source, and right now 99.99% of the people will use
the git tree for that.

Paolo