[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] qmp: revert "add set_echo implementation fo

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/2] qmp: revert "add set_echo implementation for qemu_chr_stdio"
Date: Wed, 30 May 2012 06:49:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

On 05/30/2012 04:01 AM, Pavel Hrdina wrote:
> This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this 
> code is not used
> in order that we use readline mode for '-qmp stdio'.
> Conflicts:
>       qemu-char.c

This is evidence that you've rebased locally, but as none of us know
what the patch was like before you resolved your rebase conflicts, you
should drop this portion of the commit message before posting upstream.
 Conflict designations are primarily useful on public backporting
branches, rather than on initial submissions for upstream.

As to the series itself, will readline mode add overhead?  Libvirt wants
to use QMP monitor without the overhead of remembering issued commands,
and if the difference for turning on readline is significant, then it
needs to be an opt-in option and not the default.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]