Re: [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects

[Andreas Färber]

Am 23.05.2012 17:44, schrieb Paolo Bonzini:
> The property machinery uses DeviceState arguments in a few places.
> Replace this with Object so that we can push properties up.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/qdev-addr.c       |   19 +++---
>  hw/qdev-properties.c |  180 
> +++++++++++++++++++++-----------------------------
>  hw/qdev.c            |    8 +--
>  hw/qdev.h            |   10 +--
>  4 files changed, 93 insertions(+), 124 deletions(-)
> 
> diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c
> index a3796bd..99ca116 100644
> --- a/hw/qdev-addr.c
> +++ b/hw/qdev-addr.c
[...]
> @@ -53,9 +51,8 @@ static void set_taddr(Object *obj, Visitor *v, void *opaque,
>      if ((uint64_t)value <= (uint64_t) ~(target_phys_addr_t)0) {
>          *ptr = value;
>      } else {
> -        error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
> -                  dev->id?:"", name, value, (uint64_t) 0,
> -                  (uint64_t) ~(target_phys_addr_t)0);
> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> +               name, "target_phys_addr_t");

Tab-indented here. Fixed for the upcoming version.

/-F

>      }
>  }
>  
[snip]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg