[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants
Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used
Thu, 31 May 2012 14:32:58 +0100
Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 31 May 2012, Jan Beulich wrote:
> >>> On 31.05.12 at 13:27, Stefano Stabellini <address@hidden>
> > On Thu, 31 May 2012, Jan Beulich wrote:
> >> Legacy (non-pvops) gntdev drivers may require this to be done when the
> >> number of grants intended to be used simultaneously exceeds a certain
> >> driver specific default limit.
> >> Change in v2: Double the number requested, as we need to account for
> >> the allocations needing to happen in contiguous chunks. The worst case
> >> number would be max_req * max_seg + (max_req - 1) * (max_seg - 1) + 1,
> >> but in order to keep things simple just use 2 * max_req * max_seg.
> >> Change in v3: introduce MAX_GRANTS(), and add a comment explaining its
> >> definition.
> >> Signed-off-by: Jan Beulich <address@hidden>
> > I think it is OK, I'll submit it as a bug fix for QEMU 1.1.
> > It should be applied to qemu-xen-traditional too.
> And the other one ("qemu/xendisk: properly update stats in
> ioreq_release()") probably too.
That patch is already in upstream QEMU and qemu-xen-upstream but it is
missing in qemu-xen-traditional.