[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio |
Date: |
Thu, 31 May 2012 17:18:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 31/05/2012 15:49, Luiz Capitulino ha scritto:
>> Seriously? The natural thing to do is -qmp stdio, and I don't read any
>> wikis for that.
>>
>> It's nice that you can get some kind of usability by typing in long
>> network addresses or path names and hacking a rlwrap around it (didn't
>> know this one yet), but it's not stuff I want to deal with. It should
>> just work.
>
> I'm not opposed to having this somewhere else, but adding a crude hack down
> QMP low-levels just to have readline support while the same functionality
> can be achieved by using a simple tool doesn't make much sense to me.
We can at least clean up the code so that it doesn't look like a hack,
and so that there is limited or no duplication between HMP and QMP code.
> Actually, rlwrap supports more features than our NIH readline implementation.
For HMP, it doesn't support completion.
Paolo
- Re: [Qemu-devel] [PATCH 2/2] qmp: revert "add set_echo implementation for qemu_chr_stdio", (continued)