Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

[Stefan Weil]

Hi Paolo,

I suggest using false / true instead of 0 / 1 for the boolean values,
see my comments below.

Regards,
Stefan

Am 31.05.2012 12:03, schrieb Paolo Bonzini:

[...]

> -void qemu_net_queue_flush(NetQueue *queue)
> +bool qemu_net_queue_flush(NetQueue *queue)
>   {
>       while (!QTAILQ_EMPTY(&queue->packets)) {
>           NetPacket *packet;
> @@ -248,7 +248,7 @@ void qemu_net_queue_flush(NetQueue *queue)
>                                        packet->size);
>           if (ret == 0) {
>               QTAILQ_INSERT_HEAD(&queue->packets, packet, entry);
> -            break;
> +            return 0;

s/0/false/

>           }
>
>           if (packet->sent_cb) {
> @@ -257,4 +257,5 @@ void qemu_net_queue_flush(NetQueue *queue)
>
>           g_free(packet);
>       }
> +    return 1;

s/1/true/