[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynami

From: Scott Wood
Subject: Re: [Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically
Date: Thu, 31 May 2012 17:22:01 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

On 05/31/2012 05:17 PM, Alexander Graf wrote:
> On 01.06.2012, at 00:02, Scott Wood wrote:
>> Please put this somewhere it won't have to be duplicated for every board
>> -- preferably in the serial device code itself.
> Yeah, I talked to Anthony about that and he didn't like the idea of
> devices knowing about their device tree specifics. Serial is a good
> candidate to understand why. A serial device shouldn't know if it's
> device 0 or device 1. It's just a plain device. The semantics on the
> port go with the board.

Well, cell-index should probably just be dropped.  The board code (or at
least code for the SoC family) should determine the alias name, but it
shouldn't have to take care of everything.

Consider more complicated devices with various properties describing
attributes of the device itself, that have to match what's actually
implemented.  If there is anything that is board knowledge, provide a
way for the board to add it as a supplement.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]