[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey
Date: Wed, 06 Jun 2012 05:58:18 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

On 06/06/2012 01:13 AM, Amos Kong wrote:

>>> Ho, I found another bug in my code, key in decimal or hexadecimal
>>> format is not supported. I will fix it.
>> How do you plan to support decimal in QMP?
> In old do_sendkey(), only key-name and hexadecimal were supported,
> the description needs to be fixed.

> It seems we can only support key-name for QMP, and support
> key-name/hexadecimal
> for HMP. Is it acceptable?

Yes, that was my argument for bare minimum support - anyone using QMP
(like libvirt) will have to be smart enough to use key-name only, while
anyone using HMP will be able to use hex because HMP will convert hex to
key-name at the appropriate time before calling into QMP.

Of course, being able to support hex from QMP would be a nice feature,
but I'm not sure how to add it in.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]