[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState
Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction
Wed, 06 Jun 2012 14:55:48 +0200
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
Peter Maydell <address@hidden> writes:
> On 5 June 2012 13:51, Markus Armbruster <address@hidden> wrote:
>> @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev)
>> struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev,
>> int index, qflags, info = 0;
>> + char fmt_name;
> Fixed length array with a hardcoded magic number size ?
> If the block layer guarantees that format names are going to be
> less than 128 bytes it ought to provide a suitable #define for
> people to set array sizes to...
Maybe it should, but it doesn't. Does it really matter in this
particular case? If somebody insists on giving his driver a name longer
than 127 characters, we'll silently log it truncated, that's all.
[Qemu-devel] [PATCH 1/2] xen: Don't change -drive if=xen device name during machine init, Markus Armbruster, 2012/06/05