qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/4] vl.c: allow for reapeated -sd arguments


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v3 3/4] vl.c: allow for reapeated -sd arguments
Date: Thu, 07 Jun 2012 13:57:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Speaking of typos in the cover letter, "repeated" and...

Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite:
> Allows for repeating of -sd arugments in the same way -pflash and -mtdblock

..."arguments".

> can be repeated.
> 
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>

Multiple SD controllers indeed need to be supported, patch looks good.

Andreas

> ---
>  vl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index 23ab3a3..a381e90 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2437,7 +2437,7 @@ int main(int argc, char **argv, char **envp)
>                  drive_add(IF_MTD, -1, optarg, MTD_OPTS);
>                  break;
>              case QEMU_OPTION_sd:
> -                drive_add(IF_SD, 0, optarg, SD_OPTS);
> +                drive_add(IF_SD, -1, optarg, SD_OPTS);
>                  break;
>              case QEMU_OPTION_pflash:
>                  drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]