Re: [Qemu-devel] [PATCH qom-next 0/7] QOM realize, revised

[Paolo Bonzini]

Il 07/06/2012 21:30, Andreas Färber ha scritto:
> Hi Paolo,
> 
> I've modified the remainder of your static properties series, in particular:
> 
> "qdev: Push state up to Object":
> * OBJECT_STATE_CREATED -> OBJECT_STATE_INITIALIZED, to align with QOM API
> * Don't set early in object_instance_init() but in object_init_with_type()
>   after all initfns have been run.
> 
> "qom: add get_id":
> * _object_get_id() -> object_instance_get_id(), to avoid underscore
> * Avoid GCC ?: expression, suggested by malc.
> * Use newly introduced object_property_is_child() helper.
> 
> "qdev: Generalize properties to Objects":
> * Fixed indentation.
> 
> "qdev: Move bulk of qdev-properties.c to qom/object-properties.c":
> * Documentation fix: qdev_property_add_static -> object_property_add_static
> * Move from hw/qdev-properties.c to a new qom/object-properties.c
>   instead of qom/object.c.
> 
> "qom: Push static properties to Object":
> * Build fix: Adapt arm_gic_properties in hw/arm_gic.c as well.
> 
> "qom: Add "realized" property":
> * Adapted to OBJECT_STATE_INITIALIZED.
> 
> "qom: Add QERR_PROPERTY_SET_AFTER_REALIZE":
> * Redid the hw/qdev-properties.c changes in qom/object-properties.c.
> 
> If you're okay with these, I'll append them to the qom-next queue and will
> send out the PULL.

Of course, thank you very much!

Paolo