qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id
Date: Fri, 08 Jun 2012 05:58:48 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

On 06/08/2012 01:44 AM, Anthony Liguori wrote:

> Since qdev->id is NULL 90% of the time, I don't think a user can
> realistically rely on it.  I don't think changing the type of the data
> in the error is going to be a problem.
> 
> Doesn't libvirt ignore the contents of an error object?

Libvirt tries to parse the contents of an error object in order to
reconstruct the most user-friendly message possible for libvirt's error
message.  There's already some special-casing in libvirt's code, and we
can probably add more if you change the layout of particular errors.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]