[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"

From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"
Date: Fri, 08 Jun 2012 14:05:35 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Am 08.06.2012 12:57, schrieb Stefan Hajnoczi:
On Fri, Jun 8, 2012 at 11:43 AM, Stefan Weil<address@hidden>  wrote:
Am 08.06.2012 12:08, schrieb Stefan Hajnoczi:

On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov<address@hidden>    wrote:

This should fix the following build failure:

/home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In
function 'lx_init':
warning: implicit declaration of function 'drive_get'
warning: nested extern declaration of 'drive_get'
error: 'IF_PFLASH' undeclared (first use in this function)
error: (Each undeclared identifier is reported only once
error: for each function it appears in.)
error: dereferencing pointer to incomplete type

Signed-off-by: Max Filippov<address@hidden>
  hw/xtensa_lx60.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

Reviewed-by: Stefan Hajnoczi<address@hidden>

Strange, I don't see this problem here.

xtensa_lx60.c includes pc.h which includes fdc.h which includes blockdev.h,
so this patch should not be needed.

Please check the buildbot output for more details on the failure:

The build failure for all hosts is introduced by commit
d39e6563312a8ea3fb436cd2c7e6893cf416f34e in Kevin's block-next.

Kevin, please add Max' patch before that commit.
Stefan H. already reviewed the patch, and if you want,
you can now also add

Reviewed-by: Stefan Weil <address@hidden>.

QEMU git master still uses the old code where blockdev.h is
included by hw/fdc.h, that's why I did not get that problem.


Stefan W.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]