[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object |
Date: |
Sun, 10 Jun 2012 19:38:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 10.06.2012 17:49, schrieb Paolo Bonzini:
> Il 08/06/2012 03:19, Anthony Liguori ha scritto:
>>>
>>> +typedef enum ObjectState {
>>> + OBJECT_STATE_INITIALIZED = 1,
>>> + OBJECT_STATE_REALIZED,
>>> +} ObjectState;
>>
>> I think using a bool would be better since it reduces the temptation to
>> add additional states.
>
> In fact someone already discussed having a third state for block
> devices... :)
I would expect that file_opened state to remain internal to the block
layer. Thought we discussed that on IRC?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-next 0/7] QOM realize, revised, Andreas Färber, 2012/06/07
- [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Andreas Färber, 2012/06/07
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Anthony Liguori, 2012/06/07
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Paolo Bonzini, 2012/06/10
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Anthony Liguori, 2012/06/10
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Kevin Wolf, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Anthony Liguori, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Kevin Wolf, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Andreas Färber, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Andreas Färber, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Anthony Liguori, 2012/06/11
- Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object, Andreas Färber, 2012/06/11
[Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id, Andreas Färber, 2012/06/07