[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor
Date: Mon, 11 Jun 2012 09:20:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Il 11/06/2012 09:13, Andreas Färber ha scritto:
>>> >> +The first step is to move your device struct definition to a header 
>>> >> file.  This
>>> >> +header file should only contain the struct definition and any 
>>> >> preprocessor
>>> >> +declarations you need to define the structure.  This header file will 
>>> >> act as
>>> >> +the source for the QC IDL compiler.
>> > 
>> > I don't think this is a fantastic idea -- the device struct should be
>> > private to the device, and having it in a standalone header file is
>> > asking for users of the device to illicitly include it and access
>> > internals that they shouldn't.
> But that is exactly where realize is headed. PCIBus, a9mp_priv etc.
> structs will need to be made public so that they can be embedded.

I thought that was just a convenience choice, not a necessity.  The
children objects could just as well be heap-allocated.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]