[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calc

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calculation
Date: Tue, 12 Jun 2012 16:11:11 +0100

On 8 June 2012 02:06, Maciej W. Rozycki <address@hidden> wrote:
> From: Nathan Froyd <address@hidden>
>  Nathan's original terse comment:
> "Use MIPS_HFLAG_B16 to determine the address of a jump instruction when we
> need to restart a delay slot instruction."
> and was not accompanied by a test case nor I have one offhand.
>  However this change appears obviously correct to me, and the same
> calculation is already used in exception_resume_pc applied to ordinary,
> Debug and NMI exceptions.  This code on the other hand applies to reset
> exceptions and instruction restarts in the context of I/O.

I would prefer the commit messages to be standalone justifications
for the changes. Part of cleaning up somebody else's patches for
submission to the list should include writing good commit messages
if the original patches were overly brief in that area.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]