[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private |
Date: |
Wed, 13 Jun 2012 13:27:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 13/06/12 12:58, Jan Kiszka wrote:
>> Thinking about this a bit more, how about
>>
>> } else if (!kvm_arch_vmalloc(size, &new_block->host)) {
>> <normal code>
>> }
>>
I like that. Of course, we have to have a generic kvm_arch_vmalloc
implementation
then.
>> Then the arch specific code could do the check and the implementation of
>> vmalloc, but only has to return -1 if we don't need it and things still
>> fall back to the generic code.
>
> But you would have to walk a while to find out that only s390x on (old)
> KVM actually returns success here and does some allocation.
It that such a problem? What about adding a comment then, otherwise we just
use ifdef as a comment, which isnt nice either.
Christian
- Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions, (continued)
- [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Jens Freimann, 2012/06/06
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Alexander Graf, 2012/06/12
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Christian Borntraeger, 2012/06/12
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Alexander Graf, 2012/06/12
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Christian Borntraeger, 2012/06/12
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Alexander Graf, 2012/06/12
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Alexander Graf, 2012/06/13
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Alexander Graf, 2012/06/13
- Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private, Jan Kiszka, 2012/06/13
- [Qemu-devel] Next version of memory allocation fixup, Christian Borntraeger, 2012/06/15
- [Qemu-devel] [PatchV2] s390: autodetect map private, Christian Borntraeger, 2012/06/15
- [Qemu-devel] One more fix, Christian Borntraeger, 2012/06/15
- [Qemu-devel] [PATCH v3] s390: autodetect map private, Christian Borntraeger, 2012/06/15
- Re: [Qemu-devel] [PATCH v3] s390: autodetect map private, Jan Kiszka, 2012/06/15
- Re: [Qemu-devel] [PATCH v3] s390: autodetect map private, Alexander Graf, 2012/06/18
[Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial reset, Jens Freimann, 2012/06/06