|
From: | Pavel Hrdina |
Subject: | Re: [Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling |
Date: | Wed, 13 Jun 2012 13:43:53 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 06/12/2012 02:59 PM, Paolo Bonzini wrote:
According to the code bits 0 and 1 don't have to be cleared, but it would be probably better clear them too. Good point.Il 12/06/2012 13:19, Pavel Hrdina ha scritto:} else { - /* XXX: status0 handling is broken for read/write - commands, so we do this hack. It should be suppressed - ASAP */ - fdctrl->fifo[0] = - FD_SR0_SEEK | (cur_drv->head<< 2) | GET_CUR_DRV(fdctrl); + fdctrl->fifo[0] = (fdctrl->status0& ~FD_SR0_HEAD) | GET_CUR_DRV(fdctrl);Should bit 0 be cleared also, before ORing GET_CUR_DRV(fdctrl)? Paolo
Pavel
[Prev in Thread] | Current Thread | [Next in Thread] |