Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling

[Kevin Wolf]

Am 13.06.2012 15:43, schrieb Pavel Hrdina:
> The fd_seek will return 'track is invalid' if there is no media in drive.
> 
> Implied seek should have the same behavior as normal seek. We will use the 
> fd_seek
> function instead of a direct modification of head, track and sector values.
> The result value is used only while read/write commands were issued.
> 
> Fixed sense interrupt status command.
> 
> v5:
>     - correction of misspelled words
> 
> v4:
>     - fixed coding style
>     - better bit clearing in 'fdctrl_handle_sense_interrupt_status'
> 
> v3:
>     - added fdc-test
>     - rewrited seek and media_changed handling
>     - fixed interrupt status handling
> 
> v2:
>     - better way to detect media missing
> 
> Pavel Hrdina (4):
>   fdc: fix implied seek while there is no media in drive
>   fdc-test: introduced qtest read_without_media
>   fdc: rewrite seek and DSKCHG bit handling
>   fdc: fix interrupt handling
> 
>  hw/fdc.c         |  106 
> ++++++++++++++++++++++++++++++------------------------
>  tests/fdc-test.c |   66 +++++++++++++++++++++++++++++++++
>  2 files changed, 125 insertions(+), 47 deletions(-)
> 

Thanks, I applied patches 1 and 2. For the rest I'm waiting for a v6
that includes test cases.

Kevin