[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/2] arm_boot: Conditionalised DTB command line u
From: |
Peter A. G. Crosthwaite |
Subject: |
[Qemu-devel] [PATCH v2 2/2] arm_boot: Conditionalised DTB command line update |
Date: |
Mon, 18 Jun 2012 11:35:36 +1000 |
The DTB command line should only be overwritten if the user provides a command
line with -apend. Otherwise whatever command line was in the DTB should stay
unchanged.
Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
---
changed since v1:
checked cmd line string in binfo rather than machine opt
hw/arm_boot.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/arm_boot.c b/hw/arm_boot.c
index f0fa23c..1b110ca 100644
--- a/hw/arm_boot.c
+++ b/hw/arm_boot.c
@@ -240,10 +240,12 @@ static int load_dtb(target_phys_addr_t addr, const struct
arm_boot_info *binfo)
fprintf(stderr, "couldn't set /memory/reg\n");
}
- rc = qemu_devtree_setprop_string(fdt, "/chosen", "bootargs",
- binfo->kernel_cmdline);
- if (rc < 0) {
- fprintf(stderr, "couldn't set /chosen/bootargs\n");
+ if (binfo->kernel_cmdline && *binfo->kernel_cmdline) {
+ rc = qemu_devtree_setprop_string(fdt, "/chosen", "bootargs",
+ binfo->kernel_cmdline);
+ if (rc < 0) {
+ fprintf(stderr, "couldn't set /chosen/bootargs\n");
+ }
}
if (binfo->initrd_size) {
--
1.7.3.2
- [Qemu-devel] [PATCH v2 0/2] These two patches add some flexibilities to the arm bootloader., Peter A. G. Crosthwaite, 2012/06/17
- [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter A. G. Crosthwaite, 2012/06/17
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Maydell, 2012/06/19
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Crosthwaite, 2012/06/19
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Crosthwaite, 2012/06/22
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Maydell, 2012/06/22
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Crosthwaite, 2012/06/22
- Re: [Qemu-devel] [PATCH v2 1/2] arm_boot: Assume Linux boot flow when -dtb given, Peter Crosthwaite, 2012/06/22
[Qemu-devel] [PATCH v2 2/2] arm_boot: Conditionalised DTB command line update,
Peter A. G. Crosthwaite <=