[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] make: automatically include dependencies in rec
Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)
Mon, 18 Jun 2012 10:31:48 +0100
On 18 June 2012 10:13, Jan Kiszka <address@hidden> wrote:
> On 2012-06-18 02:32, Andreas Färber wrote:
>> This will work technically but I still feel this is wrong semantically.
>> The pre-Paolo and current way is picking specific files from the hw/kvm/
>> directory. Your change above implies that in hw/kvm/ only x86 files can
>> live, which I dislike.
> Some per-arch separation is required, at least in the build process.
> We'll see power and arm stubs for in-kernel devices soon.
Indeed -- I have a hw/kvm/arm_gic.c in the qemu-linaro tree, so
if you break building that I'll have to unbreak it :-)
(Does architecture-specific separation make much sense in general?
Not all devices are architecture-specific. I'd have thought that
a functional split eg timer/serial/usb like the linux kernel layout
would be better.)
Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2), Anthony Liguori, 2012/06/20