[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_all
Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails
Mon, 18 Jun 2012 14:16:38 +0100
On Mon, Jun 18, 2012 at 2:11 PM, Kevin Wolf <address@hidden> wrote:
> Am 18.06.2012 15:00, schrieb Stefan Hajnoczi:
>> When qcow2_alloc_clusters() error handling code was introduced in commit
>> 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset
>> was clobbered in the error case. This patch keeps free_byte_offset at 0
>> so we will try to allocate clusters again next time this function is
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Thanks, applied to the block branch.
> And I guess we should get test case 026 fixed up and extended to cover this.
I'm not sure what to test. It already returned the error code
correctly. The problem was what happened when called again - there
would be junk in free_byte_offset.